fix(webhooks): make SNS processing replay-safe - #465
Open
vladbisceanu wants to merge 2 commits into
Open
Conversation
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SNS deliveries are currently acknowledged after partial failures and can replay side effects when processing fails between database writes. Any AWS account can also send a validly signed SNS envelope unless the receiver authorizes the topic.
This patch:
SNS_TOPIC_ARNSallowlist and checks it before certificate or confirmation URL I/OMessageId, with a lease for abandoned processing and a seven-day receipt windownextExisting event rows are backfilled as processed during migration. New deployments must set
SNS_TOPIC_ARNS; the self-hosting examples and CI environment document the contract.Verification:
The fork tracks tighter event-dispatch claiming and removal of swallowed workflow-start errors as separate follow-ups, so this PR stays scoped to durable SNS ingestion and retry behavior.