fix(contacts): preserve preferences during pending opt-in - #471
Draft
vladbisceanu wants to merge 1 commit into
Draft
fix(contacts): preserve preferences during pending opt-in#471vladbisceanu wants to merge 1 commit into
vladbisceanu wants to merge 1 commit into
Conversation
This was referenced Aug 27, 2026
vladbisceanu
marked this pull request as draft
August 31, 2026 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The documented double-opt-in flow currently needs two secret-key calls. A public one-call track payload with subscribed: false would unsubscribe an existing active contact, while omitting it creates a new contact subscribed.
Solution
The race path intentionally returns the elected row without replaying the losing request metadata. This matches #469: stale concurrent payloads must not overwrite winner-owned contact data. The fork version composes this behavior with that broader race hardening.
Proof
Fork tracking: vladbisceanu#16
Fork implementation: vladbisceanu#17
Related concurrency hardening: #469