fix(command): 修复 Unix 进程组终止竞态 - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
main 的 macOS CI 偶发失败:
TestRuntimeCloseCancelsForegroundCommandAndRejectsNewStarts在Runtime.Close()阶段等待 command reservation 3s 超时。根因
Unix
killpg(SIGKILL)与 shellfork存在竞态:第一次 group signal 返回成功且 shell 已终止后,刚好在 signal 快照之后出生的 child 仍可能存活,并继续持有 stdout/stderr pipe,导致cmd.Wait()不返回,reservation 无法释放。修复
sessionKillWait,避免用更大超时掩盖竞态。验证
command pipes stayed open after process-group termination。go test ./...通过。go test -race ./internal/process ./internal/tool/command ./internal/app通过。go vet ./...、Linux amd64 交叉编译、git diff --check通过。