admin management - #75
Open
jvmdev4 wants to merge 7 commits into
Open
Conversation
# Conflicts: # pom.xml # src/main/java/dev/vality/orgmanager/repository/OrganizationRepository.java
|
|
||
| private final String value; | ||
|
|
||
| StoredInviteeContactType(String value) { |
| .orElseThrow(MemberNotFound::new); | ||
| } | ||
|
|
||
| private MemberRoleEntity toMemberRoleEntity( |
There was a problem hiding this comment.
класс на 400 строк мб чето развести?
aezakmi0
reviewed
Sep 1, 2026
There was a problem hiding this comment.
Давай damsel тоже до актуальной версии бампнем
| } | ||
|
|
||
| private boolean isActive(OrganizationEntity organization) { | ||
| return organization.getStatus() == null |
There was a problem hiding this comment.
В миграции ведь добавили явное проставление статуса по дефолту, разве тут оно не применится? Т.е. будет active приходить.
И ветка с "не deactivated" может стрельнуть, если добавим однажды какой-то третий статус, а тут обработчик будет возвращать true.
aezakmi0
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.