[26.1] Further porting work - #1374
Open
cassiancc wants to merge 96 commits into
Open
Conversation
updated French translation
Update fr_fr.json
- Fixed consistency issues. - Removed all the anglicisms. - Fixed unreasonable capitalization. - Reverted some unnecessary changes. - Improved advancement headers. (I wasn't the one who translated them initially, but some of them don't seem too original for now.)
…ing for easier polymorphism
Here's some fixed to conform to the vanilla format
Some fixes to Traditional Chinese translation
Update ja_jp.json
Hanging signs should be fine but I think standing signs are broken still.
Why on earth does the client not know gamerule values? Transparency might not work properly.
May be buggy clientside.
Breaks CookingPotMenu as it was working off of ItemStackHandler
Only the server is properly aware of recipes, now, it seems. I'm really not a fan of stealing and keeping a server reference like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off #1347, which was making good work on the port.
Note: This is currently using
RegisterEventrather than Deferred Registers, as I'm pretty unfamiliar with Deferred Registers and they were throwing strange registry frozen errors. At this point, the only thing this PR does not port is block model generation. Commenting this out allows the mod to boot.