Skip to content

docs: correct the examples in the marketing pages guide #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dferber90 merged 1 commit into from
Aug 18, 2026
Merged

docs: correct the examples in the marketing pages guide #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions apps/docs/content/docs/frameworks/next/guides/marketing-pages.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import { type NextRequest, NextResponse } from 'next/server';
import { marketingFlags } from './flags';
import { getOrGenerateVisitorId } from './get-or-generate-visitor-id';

export async function marketingMiddleware(request: NextRequest) {
export async function proxy(request: NextRequest) {
// assign a cookie to the visitor
const visitorId = await getOrGenerateVisitorId(
request.cookies,
Expand Down Expand Up @@ -117,17 +117,14 @@ function and both will see the exact same id, even when no cookie was
present initially.

```tsx title="flags.tsx#next"
import type { Identify } from 'flags';
import { dedupe, flag } from 'flags/next';

// identify who is requesting the page
const identify = dedupe(
async ({
cookies,
}: {
cookies: ReadonlyRequestCookies;
}): Promise<Entities> => {
const visitorId = await getOrGenerateVisitorId(cookies);
return { visitor: visitorId ? { id: visitorId } : undefined };
},
);
const identify: Identify<Entities> = dedupe(async ({ cookies, headers }) => {
const visitorId = await getOrGenerateVisitorId(cookies, headers);
return { visitor: visitorId ? { id: visitorId } : undefined };
});

export const marketingAbTest = flag<boolean, Entities>({
key: 'marketing-ab-test-flag',
Expand Down
Loading