fix: parse live REST order status responses - #1
Merged
Conversation
The production getOrderStatus REST endpoint nests its tracking payload under OrderStatus. The parser read the response root instead, so Ack=true produced an empty DTO. Unwrap the live response while retaining compatibility with the historical flat shape, raise a parse exception when the payload is absent, add regression coverage, and document the supported label reprint fallback. Verified against the production SOAP and REST endpoints and the current DPD WSDL. All 208 unit tests (499 assertions) pass and PHPStan level 8 is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrderStatuswrapper returned by the live DPD REST endpoint while retaining compatibility with the historical flat response shape.DpdCloudResponseParseExceptionwhen a successful response has no order-status payload instead of returning an empty DTO.Verification
Release target:
v1.0.1.