Skip to content

feat(ARC-3833): add double banner content block #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RobbeBierebeeck wants to merge 9 commits into
base: release/v6.0.0
Choose a base branch
from
+1,100 −4
Open

feat(ARC-3833): add double banner content block #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1d84600
feat(ARC-3833): add double banner content block
Aug 12, 2026
e091a2d
fix(ARC-3833): improve double banner responsive layout, validation an…
Aug 13, 2026
bbc401b
fix(ARC-3833): address double banner review feedback
Aug 14, 2026
57571a5
fix(ARC-3833): use enum values for color defaults
Aug 14, 2026
e816dab
fix(ARC-3833): keep double banner half wrapper without a destination
Aug 17, 2026
2e1ae7b
Merge remote-tracking branch 'origin/release/v6.0.0' into feature/ARC…
Aug 18, 2026
04b9ea7
refactor(ARC-3833): use the shared focus-outline mixin
Aug 18, 2026
b2a95ca
refactor(ARC-3833): render the double banner icons with the shared Icon
Aug 18, 2026
ed48863
fix(ARC-3833): skip the banner image until one is uploaded
Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
322 changes: 321 additions & 1 deletion ui/all-translations-het-archief.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59198,5 +59198,325 @@
"language": "en",
"value": "You do not have the right permissions to call this route",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "achtergrondkleur-tekstvak",
"language": "nl",
"value": "Achtergrondkleur tekstvak",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "achtergrondkleur-tekstvak",
"language": "en",
"value": "Text panel background colour",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "afbeelding",
"language": "nl",
"value": "Afbeelding",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "afbeelding",
"language": "en",
"value": "Image",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "afbeelding-is-verplicht",
"language": "nl",
"value": "Afbeelding is verplicht",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "afbeelding-is-verplicht",
"language": "en",
"value": "Image is required",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "bestemming",
"language": "nl",
"value": "Bestemming",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "bestemming",
"language": "en",
"value": "Destination",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "bestemming-is-verplicht",
"language": "nl",
"value": "Bestemming is verplicht",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "bestemming-is-verplicht",
"language": "en",
"value": "Destination is required",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "dubbele-banner",
"language": "nl",
"value": "Dubbele banner",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "dubbele-banner",
"language": "en",
"value": "Double banner",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "helft",
"language": "nl",
"value": "Helft",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "helft",
"language": "en",
"value": "Half",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "icoon-1",
"language": "nl",
"value": "Icoon 1",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "icoon-1",
"language": "en",
"value": "Icon 1",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "icoon-2",
"language": "nl",
"value": "Icoon 2",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "icoon-2",
"language": "en",
"value": "Icon 2",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "icoon-3",
"language": "nl",
"value": "Icoon 3",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "icoon-3",
"language": "en",
"value": "Icon 3",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "label",
"language": "nl",
"value": "Label",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "label",
"language": "en",
"value": "Label",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "label-is-verplicht",
"language": "nl",
"value": "Label is verplicht",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "label-is-verplicht",
"language": "en",
"value": "Label is required",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "tekstkleur",
"language": "nl",
"value": "Tekstkleur",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "tekstkleur",
"language": "en",
"value": "Text colour",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/const/get-content-block-type-options",
"key": "dubbele-banner",
"language": "nl",
"value": "Dubbele banner",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/const/get-content-block-type-options",
"key": "dubbele-banner",
"language": "en",
"value": "Double banner",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "achtergrondkleur-tekstvak-is-verplicht",
"language": "nl",
"value": "Achtergrondkleur tekstvak is verplicht",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "achtergrondkleur-tekstvak-is-verplicht",
"language": "en",
"value": "Text panel background colour is required",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "tekstkleur-is-verplicht",
"language": "nl",
"value": "Tekstkleur is verplicht",
"value_type": "TEXT"
},
{
"id": "",
"app": "HET_ARCHIEF",
"component": "ADMIN_CORE",
"location": "modules/content-page/components/blocks/block-double-banner/block-double-banner",
"key": "tekstkleur-is-verplicht",
"language": "en",
"value": "Text colour is required",
"value_type": "TEXT"
}
]
]
1 change: 1 addition & 0 deletions ui/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export { BlockButtonsWrapper } from '~content-blocks/BlockButtons/BlockButtons.w
export { BlockCardsWithoutDescription } from '~content-blocks/BlockCardsWithoutDescription';
export { BlockContentPageMeta } from '~content-blocks/BlockContentPageMeta';
export { BlockCTAsWrapper } from '~content-blocks/BlockCTAs/BlockCTAs.wrapper';
export { BlockDoubleBanner } from '~content-blocks/BlockDoubleBanner';
export { BlockEventbrite } from '~content-blocks/BlockEventbrite';
export { BlockHeading } from '~content-blocks/BlockHeading/BlockHeading';
export { BlockHetArchiefHeaderSearch } from '~content-blocks/BlockHetArchiefHeaderSearch';
Expand Down
2 changes: 2 additions & 0 deletions ...admin/modules/content-page/components/ContentBlockRenderer/ContentBlockRenderer.const.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { BlockButtonsWrapper } from '~content-blocks/BlockButtons';
import { BlockCardsWithoutDescription } from '~content-blocks/BlockCardsWithoutDescription';
import { BlockContentPageMeta } from '~content-blocks/BlockContentPageMeta';
import { BlockCTAsWrapper } from '~content-blocks/BlockCTAs';
import { BlockDoubleBanner } from '~content-blocks/BlockDoubleBanner';
import { BlockEventbrite } from '~content-blocks/BlockEventbrite';
import { BlockHeading } from '~content-blocks/BlockHeading';
import { BlockHetArchiefHeaderSearch } from '~content-blocks/BlockHetArchiefHeaderSearch/BlockHetArchiefHeaderSearch';
Expand Down Expand Up @@ -99,6 +100,7 @@ export function GET_BLOCK_COMPONENT(
[ContentBlockType.HighlightText]: BlockHighlightText,
[ContentBlockType.ThemeReels]: BlockThemeReels,
[ContentBlockType.OverviewThemes]: BlockOverviewThemes,
[ContentBlockType.DoubleBanner]: BlockDoubleBanner,

// Avo specific blocks
[ContentBlockType.MediaGrid]: loadComponentFromConfig(ContentBlockType.MediaGrid),
Expand Down
Loading