Conversation
LedWizEquivalent output names had a stray "{name}\" prefix and matched no physical output. Use the flat "{name}.NN" form like every other controller.
Contributor
Author
|
Superseded by #60 — that fixes the resolver (CabinetOutputList::GetByName, matching C#'s Cabinet.Outputs[OutputName]) so the hierarchical {ctrl}{output} reference resolves without flattening it. Root cause instead of the per-controller symptom fix here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
PinOneAutoConfiguratorbuilt eachLedWizEquivalentoutput name as{name}\{name}.NN(a stray{name}\prefix). Physical outputs are named{name}.NN, so none matched. Use the flat{name}.NNform like every other controller's auto-configurator (LedWiz, Pac*, Pinscape, DudesCab).Why it matters
LedWizEquivalent::ResolveOutputsloggedResolved 0 of N outputs— the ledcontrol/toy mappings loaded but were never wired to the PinOne, so no game event could drive an output. With the fix:Resolved 63 of 63(verified on a real PinOne).Related
Same failure reported in #31 — that log shows the identical
Resolved 0 of 63 outputswith backslash-prefixedPinOne Controller 01\{0}.NNnames. It was worked around in a personal debug branch (since deleted) that never merged upstream, so the bug is still inmaster.