fix[lang]!: getter types for interfaces - #3961
Closed
charles-cooper wants to merge 5 commits into
Closed
charles-cooper wants to merge 5 commits into
charles-cooper wants to merge 5 commits into
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3961 +/- ##
===========================================
- Coverage 90.81% 58.82% -31.99%
===========================================
Files 98 95 -3
Lines 14867 14454 -413
Branches 3309 3205 -104
===========================================
- Hits 13501 8503 -4998
- Misses 945 5320 +4375
- Partials 421 631 +210 ☔ View full report in Codecov by Sentry. |
charles-cooper
force-pushed
the
fix/interface-implements
branch
from
May 1, 2024 19:41
c3eef76 to
342f950
Compare
Gas ChangesNo changes detected. Summary
|
📊 Bytecode Size Changes (venom)No changes detected. Full bytecode sizes
|
Collaborator
|
Superceded by #5228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
for interface compatibility reasons, apparently InterfaceT reported that its getter signature was AddressT(). this changes the getter signature to the "more correct" InterfaceT.
fix #3954 (comment)
fix #3701 (comment)
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture