fix[lang]: preserve ABI metadata in array types - #5264
Open
DicksonWu654 wants to merge 1 commit into
Open
DicksonWu654 wants to merge 1 commit into
DicksonWu654 wants to merge 1 commit into
Conversation
Array type parsing rebuilt the ABI description using only its type string. This discarded internalType before parsing the base type, so decimal arrays were reconstructed as int168 arrays even though scalar decimals were handled correctly. Carry the original ABI metadata through recursive array parsing. This preserves the decimal distinction at every array depth while retaining the existing int168 fallback when internalType is absent.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Preserve ABI metadata while recursively decoding fixed-size array types. This
prevents ABI entries for
decimalarrays from being reconstructed asint168arrays.
How I did it
Array decoding now carries the original ABI dictionary into the recursive
base-type call while replacing only the
typefield. This retainsinternalType: decimalthrough every array dimension. Unit tests coverone- and two-dimensional decoding, the
int168fallback, and a completecompile/ABI/reconstruction round trip.
How to verify it
Commit message
Description for the changelog
Fix ABI round trips incorrectly reconstructing decimal array elements as
int168.Cute Animal Picture