Fix stack overflow by JSON module for 'BlockchainSettings' since go1.27. - #2210
Merged
Conversation
alexeykiselev
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
UnmarshalJSONmethod of theBlockchainSettingsstruct to fix a bug with how the type alias is used during JSON unmarshalling. This change ensures the method works correctly by using a non-pointer type alias and casting the receiver appropriately.Bug fix:
UnmarshalJSONmethod inblockchain_settings.goto use a non-pointer type alias (shadowed BlockchainSettings) and cast the receiver to*shadowed, resolving issues with JSON unmarshalling.