Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe changes update resume behavior. Changed inputs invalidate stale metrics, pending inputs remain lazy, and run status counts only requested metrics. New tests cover metric recomputation, Kaldi loading, multi-source resume, and removed metric failures. ChangesResume and metric state handling
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fix three resume regressions introduced in #103:
--strict.Validation: 512 core tests passed with no skips or failures (
pytest -c ci/pytest-core.ini --rootdir=. -q, with model downloads disabled). Added regression coverage for input invalidation across interruptions, partial and complete Kaldi resumes under both identity policies and execution orders, and strict status after removing failed metrics. Black checks on changed files, fatal flake8, all three docstring gates, andgit diff --checkpass. No GPU or real-model inference was needed.Summary by CodeRabbit
Bug Fixes
Performance