chore: add a Dockerfile and document running in docker - #102
Merged
Conversation
Two targets share one dependency layer: the default builds the site and serves it from nginx with no Node in the runtime image, and `--target dev` runs the webpack dev server for working on the app with the source mounted. nginx marks the content-hashed chunks immutable and index.html and web.js no-cache, since those two keep their names across builds and index.html is what names the chunks. It listens on IPv6 as well, because localhost resolves to ::1 inside the container and the health check reaches for it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two targets share one dependency layer: the default builds the site and serves it from nginx with no Node in the runtime image, and
--target devruns the webpack dev server for working on the app with the source mounted.nginx marks the content-hashed chunks immutable and index.html and web.js no-cache, since those two keep their names across builds and index.html is what names the chunks. It listens on IPv6 as well, because localhost resolves to ::1 inside the container and the health check reaches for it.
What kind of change does this PR introduce?
docs
Did you add tests for your changes?
N/A
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Docs in place
Use of AI
Claude used to sketch out implementation and manual review to make sure its correct.