feat: sortable columns - #104
Merged
Merged
Conversation
Sorting lived in the modules page and was written against app.stats.modules, so it was the only table that could sort, and only by size. It now works on the rendered rows: a page marks a column .sortable-th and hands it a data-sort value wherever a cell does not sort the way it reads, which covers the modules of a chunk, the assets, the chunks and the module list alike. Which way a column opens is declared rather than guessed from its values, or the ids of the chunks page would count down from the last one. Tables that redraw their rows, as the module filter does, put the sort back afterwards. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sorting lived in the modules page and was written against app.stats.modules, so it was the only table that could sort, and only by size. It now works on the rendered rows: a page marks a column .sortable-th and hands it a data-sort value wherever a cell does not sort the way it reads, which covers the modules of a chunk, the assets, the chunks and the module list alike.
Which way a column opens is declared rather than guessed from its values, or the ids of the chunks page would count down from the last one. Tables that redraw their rows, as the module filter does, put the sort back afterwards.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
N/A
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Docs in place
Use of AI
Claude implemented me supervise.