feat: toggle graph - #105
Merged
Merged
Conversation
Both graph modules do their work as they load, so a page that requires one pays for the walk over every module, the sigma instance and the layout worker whether or not anyone wants to look at it. On a large enough build that is what takes the tab down, and forking the app to comment the graphs out was the only way around it. The pages now reach a graph through a facade that keeps the require behind the setting, so a graph that is off is never built. The control sits under the graph, the choice is remembered in this browser, and a build of more than 5000 modules or chunks starts with the graphs off rather than teaching the setting by crashing. Closes #38 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both graph modules do their work as they load, so a page that requires one pays for the walk over every module, the sigma instance and the layout worker whether or not anyone wants to look at it. On a large enough build that is what takes the tab down, and forking the app to comment the graphs out was the only way around it.
The pages now reach a graph through a facade that keeps the require behind the setting, so a graph that is off is never built. The control sits under the graph, the choice is remembered in this browser, and a build of more than 5000 modules or chunks starts with the graphs off rather than teaching the setting by crashing.
Closes #38
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
N/A
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A
Use of AI
Claude on imp + even on watch