chore: no chunk fallbacks - #106
Merged
Merged
Conversation
A stats file written with `stats: { chunks: false }` still names the chunk
ids on every module, so the app followed them into a chunk list that was
not there and threw on the first lookup. The chunk lookups now fall back
rather than assume: an id that leads nowhere is skipped, the fields a
stats file may omit are filled in as it is read, and a chunk page for a
chunk that is not in the file says so instead of throwing.
The README says the same for anyone who meets the error in an older
build, along with the stats options this app reads.
Closes #34
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A stats file written with
stats: { chunks: false }still names the chunk ids on every module, so the app followed them into a chunk list that was not there and threw on the first lookup. The chunk lookups now fall back rather than assume: an id that leads nowhere is skipped, the fields a stats file may omit are filled in as it is read, and a chunk page for a chunk that is not in the file says so instead of throwing.The README says the same for anyone who meets the error in an older build, along with the stats options this app reads.
Closes #34
What kind of change does this PR introduce?
bugfix/chore
Did you add tests for your changes?
N/A
Does this PR introduce a breaking change?
N/A
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Yes
Use of AI
Claude + Even, claude did most of this work.