Skip to content

[Fix] - Focus in Safari when the pressed nav button is disabled #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saugatmalla merged 4 commits into from
Aug 27, 2026
Merged

[Fix] - Focus in Safari when the pressed nav button is disabled #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4640ea
fix(issue-124) - fix the lost focus in Safari when the pressed button…
saugatmalla Aug 27, 2026
819e5c2
fix(issue-124) - add changeset
saugatmalla Aug 27, 2026
4e0e850
fix(issue-124) - remove function and move it after the check
saugatmalla Aug 27, 2026
d5cac29
chore(issue-124) - update comment
saugatmalla Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/happy-days-brush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wethegit/react-gallery": patch
---

Fix the lost focus in Safari when the pressed nav button is disabled
10 changes: 9 additions & 1 deletion src/lib/components/gallery-nav.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const GalleryNav = ({
children,
...props
}) => {
const { next, previous, loop, activeIndex, galleryItems } = useGallery()
const { next, previous, loop, activeIndex, galleryItems, itemNodes } = useGallery()

const handleClick = () => {
if (direction) next()
Expand All @@ -33,6 +33,14 @@ export const GalleryNav = ({

if (!children && !renderNavItem) return null

/*
* When the clicked/pressed button gets disabled, focus is reset
* to the document, so we are redirecting the focus within the gallery
*/
if (shouldDisable) {
itemNodes.current[activeIndex]?.focus({ focusVisible: false })
}

return (
<button
className={classnames([
Expand Down
Loading