Fix shell prompt hostname - #222
Merged
Merged
Conversation
Use the container runtime hostname in the shell prompt so Kubernetes hostname overrides are visible instead of reconstructing a stale app and environment label. Add a regression assertion for the generated prompt.
This was referenced Sep 4, 2026
csandanov
marked this pull request as ready for review
September 4, 2026 08:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell prompts currently reconstruct a hostname from application environment variables. That can display a stale value such as
wodby-1.containereven when Kubernetes assigned a friendly runtime hostname. This change makes the prompt use the container's actual hostname instead.The generated shell startup file now evaluates
hostnamewhen the shell starts. The image test suite also verifies that the generatedPS1contains that exact runtime hostname.Validation
bash -n 8/tests/tests.shdocker build --check --build-arg PHP_VER=8.3.33 .Related pull requests