Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whittling the note pool down to a single note left two rough edges in "Which notes":
nonsense for a one-note pool. It now reads "One note — it repeats until you add
another." The multi-note copy is unchanged.
to empty the pool, but nothing in the UI said so, so it read as a dead tap. The sole
remaining chip now carries
aria-disabledand a title explaining that the last notestays selected, plus a subdued
not-allowedstyle insrc/index.css.The chip keeps its
onClickand stays in the tab order rather than taking a realdisabledattribute, so keyboard and screen-reader users can still land on it and hearwhy it won't toggle. The reducer guard itself is untouched — it's the behaviour being
explained.
Verification
npm run check(lint, e2e typecheck, vitest, build) passes — 437 tests across 37 files.New
src/components/NotePoolCard.test.tsxcovers the singular copy, the multi-note copyand the locked chip (including that unselected chips get neither attribute); the existing
App.integration.test.tsxpool-guarantee assertions stay green.Live preview (this branch): https://agents.marten-gecko.ts.net:15511/