Skip to content

ci: route release publish install through Socket Firewall - #22

Merged
peakematt merged 3 commits into
mainfrom
security/socket-firewall-pub-sdk-pnpm
Sep 11, 2026
Merged

peakematt merged 3 commits into
mainfrom
security/socket-firewall-pub-sdk-pnpm

Conversation

@peakematt

@peakematt peakematt commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This repository installs public npm packages in three GitHub Actions paths: ordinary CI, the package release workflow, and the scheduled Socket reachability scan. Before this change, the CI install was still unscreened, and the release workflow only covered the package install itself.

This change routes those dependency downloads through the WorkOS Socket Firewall. CI now runs with read-only contents permission, checks out without persisted credentials, and enables the action's validated external-fork fallback only for the ordinary public pull_request path. Same-repository pull requests and main pushes still fail closed when the public firewall token is unavailable.

The release workflow now configures the firewall before the pnpm manager setup, configures it again after actions/setup-node writes the npm registry setting, and tears it down immediately after pnpm install. The build and publish commands stay the same, including public access, trusted publishing provenance, latest/next tagging, and prerelease routing.

The scheduled Socket analysis still uses its separate Socket API token. Its npm CLI install is screened by the firewall, then the public registry is restored before the scan uploads manifests to Socket.

Verify by checking .github/workflows/ci.yml, .github/workflows/release.yml, and .github/workflows/socket-tier1-analysis.yml, then run actionlint .github/workflows/*.yml.

@peakematt
peakematt marked this pull request as ready for review September 8, 2026 20:44

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the previously reported unscreened reachability downloads now covered by the firewall.

Summary

  • CI gains read-only repository permissions, non-persisted checkout credentials, and external-fork fallback for public pull requests.
  • Release setup screens both the pnpm bootstrap and dependency installation, then restores the public registry before build and publish.
  • Scheduled reachability analysis keeps the firewall active through the scan and restores the registry afterward, resolving the previous finding.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Checkout] --> B[Configure Socket Firewall]
    B --> C[Install package manager or Socket CLI]
    C --> D[Configure firewall again when setup-node rewrites registry]
    D --> E[Install or analyze dependencies]
    E --> F[Restore public npm registry]
    F --> G[Build and publish or finish scan]
Loading

Reviews (2) · Last reviewed commit: "ci: keep Socket Firewall active during r..."

Comment thread .github/workflows/socket-tier1-analysis.yml Outdated
@peakematt
peakematt merged commit ba6cc3e into main Sep 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants