docs: Match TanStack Start's Node minimum - #121
Open
mitch-fultz wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@workos/typescript: please review the one-line Node minimum correction. GitHub rejected formal team assignment with HTTP 422 ( |
Contributor
|
Contributor
|
not opposed but package.json does not list this authkit-tanstack-start/package.json Line 35 in 0305539 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
The published AuthKit 0.11.0 package declares Node
>=22.11.0, but its required TanStack Start 1.168.25 package declares Node>=22.12.0. The guide describes the combined application requirements, so the framework's higher floor applies. Both manifests were checked inside integrity-verified published tarballs. This is not a claim that a Node 22.11 application crash was reproduced.Test plan
Validated the clean commit with Node 24.21.0 and CI's pnpm major 10 (10.34.5):
pnpm install --frozen-lockfile— no manifest or lockfile changes.pnpm run format:check,pnpm run lint,pnpm run build,pnpm run typecheck— passed.pnpm run test:coverage -- --run— 21 files / 250 tests passed.pnpm --dir example buildandpnpm run build:check— passed; no server-only fingerprints in the client bundle.git diff --checkpassed.The build's native
npm run cleanemits existing npm config-name warnings (npm-globalconfig,always-auth,verify-deps-before-run,_jsr-registry). No configuration was changed or warning suppressed; compiler and example builds passed.Related work
Related: DOC-593 and TARS-1411.
These references intentionally do not close either issue. The source correction still needs normal review/merge, native README sync and docs publication, followed by shared-index and fresh-answer verification. No generated mirror was hand-edited, and no merge, sync dispatch, release, browser, index or model operation was performed for this PR.