Skip to content

docs: Match TanStack Start's Node minimum - #121

Open
mitch-fultz wants to merge 1 commit into
mainfrom
docs/doc-593-node-framework-minimum
Open

docs: Match TanStack Start's Node minimum#121
mitch-fultz wants to merge 1 commit into
mainfrom
docs/doc-593-node-framework-minimum

Conversation

@mitch-fultz

Copy link
Copy Markdown
Contributor

Summary

  • Change the README's Node compatibility minimum from 22.11.0+ to 22.12.0+ so it satisfies the already-required TanStack Start 1.168.25 framework.
  • Keep both Start values, SDK engines/runtime, examples, manifests, lockfiles and all other README content unchanged. This is one prose-line change; no package release is needed.

Evidence

The published AuthKit 0.11.0 package declares Node >=22.11.0, but its required TanStack Start 1.168.25 package declares Node >=22.12.0. The guide describes the combined application requirements, so the framework's higher floor applies. Both manifests were checked inside integrity-verified published tarballs. This is not a claim that a Node 22.11 application crash was reproduced.

Test plan

Validated the clean commit with Node 24.21.0 and CI's pnpm major 10 (10.34.5):

  • pnpm install --frozen-lockfile — no manifest or lockfile changes.
  • pnpm run format:check, pnpm run lint, pnpm run build, pnpm run typecheck — passed.
  • pnpm run test:coverage -- --run21 files / 250 tests passed.
  • pnpm --dir example build and pnpm run build:check — passed; no server-only fingerprints in the client bundle.
  • Focused contract/diff check — exactly one README line changed, both Start clauses preserved, installed and published minimum Start manifests agree on Node 22.12.0; git diff --check passed.

The build's native npm run clean emits existing npm config-name warnings (npm-globalconfig, always-auth, verify-deps-before-run, _jsr-registry). No configuration was changed or warning suppressed; compiler and example builds passed.

Related work

Related: DOC-593 and TARS-1411.

These references intentionally do not close either issue. The source correction still needs normal review/merge, native README sync and docs publication, followed by shared-index and fresh-answer verification. No generated mirror was hand-edited, and no merge, sync dispatch, release, browser, index or model operation was performed for this PR.

@linear-code

linear-code Bot commented Sep 11, 2026

Copy link
Copy Markdown

DOC-593

@mitch-fultz

Copy link
Copy Markdown
Contributor Author

@workos/typescript: please review the one-line Node minimum correction. GitHub rejected formal team assignment with HTTP 422 (Reviews may only be requested from collaborators); @nicknisi and @gjtorikian have actual individual review requests. No permissions or review gates were changed.

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the documentation now reflects the effective Node.js minimum imposed by TanStack Start.

Summary

  • Leaves package manifests, dependencies, and runtime behavior unchanged.
  • No security concerns or actionable documentation issues were identified.

Reviews (1) · Last reviewed commit: "docs: Match TanStack Start's Node minimu..."

@gjtorikian

Copy link
Copy Markdown
Contributor

not opposed but package.json does not list this

"node": ">=22.11.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants