Skip to content

Mount IT contacts on their own ItContacts service - #110

Open
jonatascastro12 wants to merge 1 commit into
mainfrom
devin/1787249011-it-contacts-naming
Open

Mount IT contacts on their own ItContacts service#110
jonatascastro12 wants to merge 1 commit into
mainfrom
devin/1787249011-it-contacts-naming

Conversation

@jonatascastro12

Copy link
Copy Markdown

Summary

The IT Contacts endpoints landed in the spec (#109) under the organizations.it-contacts tag, and default resolution produces a service and method names that leak the tag and the path prefix:

OrganizationsItContacts.list_organization_it_contacts
OrganizationsItContacts.create_organization_it_contact
OrganizationsItContacts.delete_organization_it_contact
OrganizationsItContacts.create_it_contact_invite   # sub-resource named after the path segment
OrganizationsItContacts.revoke_it_contact

This mounts the tag on ItContacts and names the operations after the resource/action, so it reads like Groups — an org-scoped resource with its own service, org passed as an option:

ItContacts.list_it_contacts / create_it_contact / delete_it_contact
          / invite_it_contact / revoke_it_contact

Node then generates workos.itContacts.listItContacts({ organizationId }) etc.

No SDK has generated IT Contacts yet, so there is no compat baseline to break — this is the last cheap point to fix the names, and the hints are language-agnostic so every SDK gets them.

Verified with npm run sdk:resolve:

| OrganizationsItContacts | GET | /organizations/{organization_id}/it_contacts | `list_it_contacts` | yes | ItContacts |

Link to Devin session: https://app.devin.ai/sessions/2633e183d1b146d6a18a87e0e1b9c42b
Requested by: @jonatascastro12

Default resolution produced organizationsItContacts.listOrganizationItContacts and
createItContactInvite. Mount the OrganizationsItContacts tag on ItContacts and name
the operations after the resource/action, matching Groups. No SDK has generated IT
Contacts yet, so no compat baseline is affected.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor
Original prompt from jonatas

Please work on ticket "Add IT Contacts API to Node SDK" (ENT-6867)

@playbook:playbook-b0d9a34380374c3e903d900d340d8da7

@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown

Greptile Summary

The PR gives organization-scoped IT Contacts a dedicated generated SDK service and concise resource-oriented operation names.

  • Remounts OrganizationsItContacts onto ItContacts.
  • Renames all five IT Contacts operations for consistent cross-language SDK generation.

Confidence Score: 5/5

The PR appears safe to merge, with the mount and operation hints consistently matching the current IT Contacts API surface.

The exact service remount and all five operation-hint identities align with the current spec, and no conflicting mounts, overrides, or method names were identified.

Important Files Changed

Filename Overview
src/policy/mount-rules.ts Adds an exact remount from the resolved organization IT Contacts service to the dedicated ItContacts namespace.
src/policy/operation-hints.ts Adds matching name overrides for all five current IT Contacts endpoints without path-key or method-name conflicts.

Reviews (1): Last reviewed commit: "Mount IT contacts on their own ItContact..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant