Mount flag target type endpoints as FlagTargetTypes - #112
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Original prompt from deborah.digges
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Greptile SummaryAdds an exact SDK mount rule so upcoming
Confidence Score: 5/5The PR appears safe to merge because the new static mount mapping is consistent with existing service-name derivation and introduces no current failure path. The change only adds an exact mapping for an upcoming service key, and the current specification contains no endpoints that could be incorrectly remounted by it. Important Files Changed
Reviews (1): Last reviewed commit: "Mount flag target type endpoints as Flag..." | Re-trigger Greptile |
Summary
Adds the mount rule for the upcoming
/flag_target_typesendpoints (AUTH-6891):The endpoints carry the
feature-flags.target-typesOpenAPI tag, so without a rule they'd surface as aFeatureFlagsTargetTypesservice. This keeps them as their own resource named to match the standaloneFlagTargetsresource (/flag_targets), giving SDK surfaces likeworkos.flagTargetTypes/workos.flagTargets(see workos/workos-node#1683)./flag_targetsneeds no rule — its path-root-derivedFlagTargetsname is already correct, and derived operation names (list_flag_targets,create_flag_target_type, ...) need no hints.The endpoints are still excluded from the published spec (
@ApiExcludeController()in the monorepo); this rule takes effect when they go public, and was validated against a locally generated spec that includes them.Link to Devin session: https://app.devin.ai/sessions/fdf25eeb8122400891ee756d079bfbeb
Requested by: @Deborah-Digges