Skip to content

Highlight multi-patch support - #69

Merged
Frotty merged 3 commits into
masterfrom
agent/multi-patch-site-copy
Aug 6, 2026
Merged

Highlight multi-patch support#69
Frotty merged 3 commits into
masterfrom
agent/multi-patch-site-copy

Conversation

@Frotty

@Frotty Frotty commented Aug 5, 2026

Copy link
Copy Markdown
Member

What changed

  • Highlight Grill's patch-level selection and matching core Jass and standard library downloads.
  • Explain classic Jass/MPQ and Reforged Lua/CASC workflows together.
  • Document client/game-data detection and the VS Code asset preview path.

Why

Wurst supports multiple Warcraft III generations across the toolchain, not only inside VS Code. The site should make that patch-aware workflow visible to users targeting older clients as well as Reforged.

Validation

  • npm test
  • Jekyll build
  • git diff --check

@Frotty
Frotty marked this pull request as ready for review August 5, 2026 19:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1472b4dc3f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread _doc/features.md Outdated

| Target | Typical output | Installed game data |
| --- | --- | --- |
| Classic / pre-Reforged patch | Jass | Layered MPQ archives |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Split CASC-backed classic patches from MPQ targets

For projects targeting Warcraft III 1.30/1.31, the target is still pre-Reforged/classic, but those installed clients use CASC-backed game data rather than the layered MPQ files listed here. As written, the table sends those users down the wrong game-data workflow; please narrow the MPQ row to older MPQ-era patches or add a separate pre-Reforged CASC row for 1.30/1.31.

Useful? React with 👍 / 👎.

Frotty commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@codex review

Addressed the P2 review feedback in 400182c. The site now distinguishes older MPQ-era classic patches, classic CASC-era patches such as Warcraft III 1.30/1.31, and Reforged CASC clients across the feature overview, installation guide, and VS Code game-data documentation.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 400182c01f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread _doc/features/vscode.md Outdated

Wurst can also read assets directly from the Warcraft III installation — not only from files inside your project. This works with both Reforged CASC storage and classic Warcraft III MPQ installations.

For classic installations, Wurst follows the game’s layered archive model, resolving files through the base game, expansion, locale, and patch archives so patched assets override their older versions:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Narrow the MPQ archive note to MPQ-era clients

For projects targeting classic CASC clients such as Warcraft III 1.30/1.31, this sentence still describes “classic installations” as following the layered MPQ archive model, even though the section now defines those clients as classic and CASC-backed. Those users will not have the listed war3.mpq/war3patch.mpq game-data archives, so this should be scoped to older MPQ-era installations instead of all classic installations.

Useful? React with 👍 / 👎.

Frotty commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@codex review

Addressed the remaining P2 in 69fa382 by scoping the layered MPQ archive description to MPQ-era classic installations. Also included the website component polish pass: scoped navigation styling, improved card focus/hover behavior, responsive spacing, image alt text, navigation labeling, and safe external-link attributes.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 69fa382be4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Frotty
Frotty merged commit f0708ae into master Aug 6, 2026
2 checks passed
@Frotty
Frotty deleted the agent/multi-patch-site-copy branch August 6, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant