XERK-678: fix malformed WinSW descriptor (XML comment '--') that broke every Windows install - #727
Merged
Conversation
… the launcher supervisor test
The XERK-698 log-path comment in turma-agent.xml contained `--` INSIDE an XML
comment (`...turma-agent.out.log) -- NOT the`), which is illegal XML. WinSW
refuses to load the descriptor ("An XML comment cannot contain '--'"), so on
every v1.3.33 install the service never registers and the follow-on
`sc.exe config` fails 1060. Observed on a real host: install left NO service.
CI never caught it because nothing validates the descriptor as XML — the render
test only checked placeholder substitution. Fix: reword the comment, and add a
well-formed-XML assertion on the RENDERED descriptor to test_install_ps1.ps1
case 3 (mutation-verified: restoring `--` fails it).
Also deflake the launcher suite's "a second launch leaves exactly one
supervisor" case: the second launch reaps the prior supervisor before starting
its own, so the count transiently passes through 0; the old `Wait-For{>=1};
sleep; count` raced that gap and read 0 on a loaded CI runner (it flaked #727
twice). Wait until it SETTLES at exactly one, then confirm it stays one — which
still catches the real duplicate-supervisor bug (persists at 2, never settles).
xerhab
force-pushed
the
XERK-678-xmlfix
branch
from
September 8, 2026 18:26
b516e48 to
a2e181d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XERK-698 log-path comment in
turma-agent.xmlhas--inside an XML comment, which is illegal XML. WinSW rejects the descriptor (An XML comment cannot contain '--'), so on every v1.3.33 install the service never registers andsc.exe configthen fails 1060. Observed on a real host (MAXAI-WIN): install left no service.Fix: reword the comment (drop the
--), and add a well-formed-XML assertion on the rendered descriptor totest_install_ps1.ps1case 3 (CI had no XML-validity gate — the root cause it shipped). Mutation-verified: restoring the--fails the new assertion; the full install suite passes with the fix.Unblocks Windows installs on the next release. Found during XERK-678 real-host validation.