ci: replace memory-heavy client-go compatibility case - #45
Merged
zhouguangyuan0718 merged 1 commit intoAug 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Review: replace top-level k8s.io/client-go in the LLGo compatibility set
This is a config/manifest-only change. It excludes the top-level k8s.io/client-go package from the client_go compatibility set and, because cmd/bent/configs/benchmarks-llgo-compatibility.toml is generated from projects.toml by generate_manifest.py, the generated manifest shifts each client_go_NNN entry up by one and backfills k8s.io/client-go/util/cert as the new client_go_040.
Verified
Limit = 40unchanged; total across all projects still sums to 200; the manifest still lists exactly 40client_go_*entries and 200[[Benchmarks]]total.- The generated
client_goRepolist is still strictly sorted and theDO NOT EDITheader is intact — the diff is exactly what re-running the generator produces, soprojects.tomland the generated artifact are in sync (not hand-edited). - The new entry
k8s.io/client-go/util/certis genuinely lightweight: its compile+test closure atv0.36.2is stdlibcrypto/*plusutil/keyutil(stdlib-only) andk8s.io/utils/net— no clientset/informer/apimachinery. It cannot reintroduce the excluded memory pressure, so the swap is a net reduction in runner resource use. - Both TOML files parse cleanly. No security concerns: sources stay on upstream
kubernetes/client-go, versions stay pinned to@v0.36.2, no secrets, no executable code changed.
One minor comment on the exclusion rationale (inline). Overall the change is correct, self-consistent, and low-risk.
zhouguangyuan0718
force-pushed
the
codex/replace-client-go-compatibility
branch
from
August 30, 2026 07:32
0d2983d to
9c25e1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
The removed root package reached about 25.2 GiB peak RSS locally and was terminated twice at the same stage on the 16 GB GitHub-hosted runner.