Fix cross-platform (non-Windows) test failures in process agent, artifact URIs, code grader, LSP path test - #8
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…s, code grader shell args, and LSP path test Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full suite on Linux: 2239 → 2237 passing / 2 failing. Seven of the nine failures were real non-Windows bugs, not test noise:
ProcessAgent:StandardInput.Close()sat outside thetry { WriteLineAsync } catch (IOException), so a child that exits before reading its task JSON broke the pipe twice — the write was caught, the close wasn't. Moved the close inside thetry.LocalArtifactStore.GetAccessUrl:new Uri($"file:///{fullPath}")yieldsfile://tmp/xon Unix (the leading/of/tmpcollapses into the authority slashes). Nownew Uri(fullPath, UriKind.Absolute).CodeGrader: on Unix the shell script was passed as a flatArguments = $"-c {expandedCommand}", which whitespace-splits intosh -c grep -q ... filesoshonly ever sawgrep. Now usesArgumentList.Add("-c"); ArgumentList.Add(expandedCommand); Windows keepscmd /c <string>.LspClientTests.PathToUri_Converts_Windows_Path: the inputs are drive-letter paths andPathToUricallsPath.GetFullPath, which only treatsC:\...as rooted on Windows. Guarded the theory withif (!OperatingSystem.IsWindows()) return;.All four bugs also exist on
ramseur/sovrantdevelopment(verified by running those projects in a clean worktree of upstream), so this isn't merge fallout.Still failing (not fixed here — product decision)
ModelOverrideLoaderTests.LoadAll_RegistersBundledOverrides/LoadAll_OllamaGlob_SetsWorkaround. The gemma-4 entries insrc/Sovrant.Api/Capabilities/model-overrides.jsoncarry"expires": "2026-07-01", andLoadFromStreamcorrectly skips expired entries — so as of today the bundled overrides no longer register and the tests fall back toCapabilitySource.Default. The expiry mechanism is working as designed; the fix is either to extend/remove the expiry or to retire the workaround and the tests with it. Left alone rather than guessing.Link to Devin session: https://app.devin.ai/sessions/d1b1be50c04f4787bcc00befb37bf805
Open in Devin Desktop: https://app.devin.ai/desktop/session/d1b1be50c04f4787bcc00befb37bf805?variant=devin
Requested by: @xingh