Conversation
Signed-off-by: Robert McConnell <robert@mcc0nnell.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject invalid bit counts before they can participate in pointer or size arithmetic in the bit-packing helpers.
Without these checks:
oggpack_writetrunc(..., -8)moves the write pointer one byte before the allocated buffer and triggers an ASan heap-buffer-overflow.oggpack_writecopy(..., -8)passes a negative byte count tomemmove(), reported by ASan asnegative-size-param.oggpack_adv(..., -8)moves the read pointer before the input buffer; the next read triggers an ASan buffer underflow.oggpack_writecopy(..., LONG_MAX)overflowsb->endbit + bits, reported by UBSan as signed integer overflow.The change rejects negative truncation/copy/advance counts, prevents overflow while sizing write-copy storage, and treats attempts to truncate past the current write position as invalid. It applies the same behavior to the MSb variants.
Regression coverage exercises the invalid-count paths in the built-in bitwise self-test.
Validation:
LONG_MAXwritecopy: pass after fix-Wall -Wextra -Werrorself-test build: pass