Skip to content

persistent/fix: make loggedClose uninterruptible - #1637

Open
swamp-agr wants to merge 3 commits into
yesodweb:masterfrom
chordify:fix-persistent-only-resource-pool-regression
Open

persistent/fix: make loggedClose uninterruptible#1637
swamp-agr wants to merge 3 commits into
yesodweb:masterfrom
chordify:fix-persistent-only-resource-pool-regression

Conversation

@swamp-agr

@swamp-agr swamp-agr commented Aug 26, 2026

Copy link
Copy Markdown

Since resource-pool-0.5.0.0 closing connections is no longer uninterruptible. There are reasons for this breaking behavioural changes and they need to be addressed on consumer side.

Closes #1636.

Before submitting your PR, check that you've:

  • Ran fourmolu on any changed files (restyled will do this for you, so
    accept the suggested changes if it makes them)
  • Adhered to the code style (see the .editorconfig and fourmolu.yaml files for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression since bumping resource-pool from 0.4.0.0 to 0.5.x

1 participant