feat: change pageSetType metadata field to pageGroupType - #1317
Closed
a-friedman wants to merge 2 commits into
Closed
feat: change pageSetType metadata field to pageGroupType#1317a-friedman wants to merge 2 commits into
a-friedman wants to merge 2 commits into
Conversation
a-friedman
requested review from
benlife5,
briantstephan and
jwartofsky-yext
September 10, 2026 14:44
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
auto-screenshot-update: true
benlife5
reviewed
Sep 10, 2026
benlife5
left a comment
benlife5
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I think there's also a pageset reference that gets copied intot he section library at src/cli/commands/internal/exportDirectoryLocatorSectionLibrary.ts#443
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
pageSetTypefield in themetadata.jsonfile to instead bepageGroupType. Only changes the external name; internal references still usepageSetType.J=SPRUMO-210
TEST=auto
Ran unit tests