Conversation
2200連打中のnotes/create過渡失敗を検出できるようstatus検証+最大3回リトライを追加し、users/showのnotesCount確認を60秒ポーリング化 (CI: Expected 2200 notes, but got 2199 対策)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.11.x #1360 +/- ##
==========================================
- Coverage 23.68% 23.24% -0.44%
==========================================
Files 1269 1267 -2
Lines 49135 48922 -213
Branches 14471 14433 -38
==========================================
- Hits 11637 11373 -264
- Misses 29599 29636 +37
- Partials 7899 7913 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Backend memory usage comparisonBefore GC
After GC
After Request
|
Contributor
|
このPRによるapi.jsonの差分 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
packages/backend/test/e2e/advanced-search.tsのfullIndexNoteE2E準備処理を堅牢化しました(テストのみの変更、本体ロジックの変更なし)。notes/create連打をステータス検証付きに変更し、失敗時は最大3回リトライ(失敗箇所のiと最終レスポンスをエラーメッセージに含める)users/show.notesCount確認を単発strictEqualから60秒ポーリングに変更Why
opensearch-e2eでフレーキーな失敗が発生していました:連打中の1件の過渡失敗が無チェックの
post()で黙って握りつぶされ、そのまま off-by-one になるのが原因と判断しました。notesCountの反映遅延も単発assertでは吸収できませんでした。Additional info (optional)
pnpm build、pnpm --filter backend typecheck、pnpm --filter backend eslint通過test:e2e:opensearch(要DB/Redis/OpenSearchのためCIでの確認が必要)yojo-art/1.11.x、他ファイル・locale・migration・API定義の変更なしChecklist