feat(ui): Guarantee consuming-app global CSS can't distort Bible components - Shadow DOM - #348
Draft
cameronapak wants to merge 12 commits into
Draft
feat(ui): Guarantee consuming-app global CSS can't distort Bible components - Shadow DOM#348cameronapak wants to merge 12 commits into
cameronapak wants to merge 12 commits into
Conversation
* feat(ui)!: prototype automatic Shadow DOM isolation * docs(examples): add hostile CSS POC demo * docs(examples): clarify hostile CSS vectors * docs(ui): align shadow DOM prototype ADR * test(ui): strengthen shadow isolation proof * refactor(ui): remove shadow isolation type assertions * fix(ui): block hostile shadow host pseudo-elements * docs(ui): clarify shadow isolation trade-offs * test(ui): align shadow isolation demo conventions * docs(examples): keep hostile demo labels readable * fix(ui): use style precedence for shadow fallback stylesheet Addresses PR review feedback: the non-adoptedStyleSheets fallback rendered a bare <style> tag inside the shadow-root portal. Use React 19's <style href precedence> resource form instead so React hoists and de-duplicates the stylesheet within the shadow root rather than risking duplicate insertion. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: abharms <aharms@works24.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 0222ae9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* feat(ui): prototype shadow-local top-layer popovers * fix(ui): reconcile shadow portal strategy changes * fix(ui): narrow shadow portal spike scope * fix(ui): harden shadow portal lifecycle --------- Co-authored-by: abharms <aharms@works24.com>
* feat(ui): validate shadow DOM dialog top layer * docs(ui): separate shadow DOM rollout plan * refactor(ui): simplify shadow dialog coordination * test(ui): prove shadow dialog escapes clipping * refactor(ui): tighten shadow dialog portal behavior --------- Co-authored-by: abharms <aharms@works24.com>
…sion/platform-sdk-react into journey-to-the-shadow-dom
* fix(ui): harden Shadow DOM CSS isolation * test(ui): cover InputGroup SDK radius token * test(ui): align input group radius assertion --------- Co-authored-by: abharms <aharms@works24.com>
* fix(ui): route verse actions through shadow portals * style(ui): use logical overflow in shadow story * fix(ui): address verse action popover review feedback --------- Co-authored-by: abharms <aharms@works24.com>
…journey-to-the-shadow-dom
* test(ui): validate shadow consumer compatibility (YPE-5436) * test(ui): strengthen shadow compatibility evidence (YPE-5436) * test(ui): await shadow content rendering (YPE-5436) * docs(ui): qualify shadow automation guidance (YPE-5436) * docs(ui): clarify shadow compatibility stories (YPE-5436) * docs(ui): tighten shadow rollout research handoff (YPE-5436) * test(ui): remove instructional copy assertions * test(ui): address YPE-5436 review feedback --------- Co-authored-by: abharms <aharms@works24.com>
) * test(ui): prove nested overlays through the production shadow seam Exercise YPE-5355 nested and concurrent overlay scenarios against the real ShadowRootHost + Radix path, without adding an ownership registry. * fix(ui): restore shadow dialog focus after a rapid reopen The production seam handled nested and concurrent overlays without a new ownership registry. Rapid reopen during exit captured the outgoing overlay as the restore target; skip portal-container nodes and fall back to the last wrapper control. * test(ui): add static Storybook frames for the production overlay seam Leave the ticket scenarios on screen so the production VerseActionPopover, permission dialog, nested popover, and independent overlays can be inspected without racing the play function. * test(ui): finalize YPE-5355 overlay evidence * docs: keep overlay proof evidence-only --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: abharms <aharms@works24.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in progress and will continue to be defined. This PR was created as a feature branch for https://lifechurch.atlassian.net/browse/YPE-4113.
Greptile Summary
The PR prototypes automatic Shadow DOM style isolation for
YouVersionAuthButtonand documents the resulting compatibility boundaries.Confidence Score: 5/5
The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Consumer[Consumer application] --> Host[Light-DOM shadow host] Host --> Root[Open shadow root] Styles[Embedded SDK stylesheet] --> Root Root --> Portal[React portal] Portal --> Button[YouVersionAuthButton implementation] HostCSS[Consumer global CSS] -. selector boundary .-> HostReviews (3): Last reviewed commit: "Merge branch 'main' into journey-to-the-..." | Re-trigger Greptile
Context used (3)