Price the five models the savings table was missing - #6
Merged
Conversation
…vings table was missing Checked ZGPU_PRICING against the dashboard model-pricing API (api-dashboard.zerogpu.ai/api/model-pricing/with-model), the authoritative price list behind the catalog. Five ids it serves had no entry here, so every call routed to one of them fell through to ZGPU_FALLBACK and was costed at glm-5.2's $1.10/$3.50. zlm-v1-moderation-edge $0.02 / $0.05 t5-small $0.05 / $0.40 zlm-v1-multi-iab-classify $0.05 / $0.40 all-minilm-l6-v2 $0.50 / not billed bge-small-en-v1.5 $0.50 / not billed zlm-v1-moderation-edge is the one that was actually costing users accuracy: it has been in the published catalog since the moderation docs landed, and the fallback prices it 55x over on input. Because savings are reported as baseline minus ZeroGPU cost, overstating the ZeroGPU rate *understates* what the user saved, which is the safe direction to be wrong in but still wrong. The two embedding models bill input tokens only, so `out: 0` is the real published rate rather than a placeholder, and the comment says so to stop a future reader from "fixing" it. No CLI command routes to an embedding model yet; they are priced so the table stays a faithful mirror of the catalog and so the two-way test below keeps passing once the docs list them. ZGPU_FALLBACK is unchanged: glm-5.2 at $1.10/$3.50 is still the priciest published rate, so the "never overstates savings" invariant still holds. The catalog transcription in tests/savings.test.ts is updated in step, which is what forces src/lib/savings.ts to change with the catalog in both directions. That table now carries one deliberate exception, documented inline: zlm-v1-followup-questions-edge was dropped from the published catalog when the model was deprecated, but `zerogpu generate-followups` still routes to it, so the CLI must still price it. Both entries should go together when that command does. All 40 tests pass; tsc --noEmit and eslint are clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked
ZGPU_PRICINGagainst the dashboard model-pricing API (api-dashboard.zerogpu.ai/api/model-pricing/with-model), the authoritative price list behind the published catalog. Five ids it serves had no entry here, so any call routed to one of them fell through toZGPU_FALLBACKand was costed at glm-5.2's $1.10 / $3.50.zlm-v1-moderation-edget5-smallzlm-v1-multi-iab-classifyall-minilm-l6-v2bge-small-en-v1.5The one that was actually costing accuracy
zlm-v1-moderation-edgehas been in the published catalog since the moderation docs landed, and the fallback prices it 55x over on input. Savings are reported as baseline cost minus ZeroGPU cost, so overstating the ZeroGPU rate understates what the user saved. That is the safe direction to be wrong in, but it is still wrong, and this is the one number in the table a user is asked to trust.The other four are new to the catalog; nothing was misreporting them yet.
Notes
out: 0on the embedding models is the real rate, not a placeholder. Embeddings bill input tokens only. There is a comment saying so, to stop a future reader from "fixing" it.zerogpu embedcommand is a separate conversation; this PR does not add one.ZGPU_FALLBACKis unchanged. glm-5.2 at $1.10 / $3.50 is still the priciest published rate, so the "never overstates savings" invariant still holds.The test transcription now has one documented exception
tests/savings.test.tspinsZGPU_PRICINGto the catalog in both directions, which is what forces this table to move when the catalog does. ItsCATALOGconstant is updated in step, and now carries an inline note about the one entry that is deliberately not in the published catalog:zlm-v1-followup-questions-edgewas dropped from the catalog when the model was deprecated, butzerogpu generate-followupsstill routes to it, so the CLI must still price it. Both entries should be removed together when that command goes.Verification
tsc --noEmitclean,eslint .cleansrc/lib/savings.tsandtests/savings.test.ts; both files already fail--checkonorigin/main, so this PR does not reformat them and add noise to the diffRelated
Docs side: zerogpu/docs#23 adds these models to the published catalog. Independent to merge, but they should land together so neither transcription is stale.
🤖 Generated with Claude Code