Skip to content

CP-47363: Upgrade prometheus-config-reloader to v0.93.1 - #1004

Open
evan-cz wants to merge 1 commit into
CP-47362-grype-outputfrom
CP-47363-reloader
Open

CP-47363: Upgrade prometheus-config-reloader to v0.93.1#1004
evan-cz wants to merge 1 commit into
CP-47362-grype-outputfrom
CP-47363-reloader

Conversation

@evan-cz

@evan-cz evan-cz commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Stacked on #1003.

Brings the bundled config reloader up two minor versions (v0.91.0 → v0.93.1), picking up upstream's own dependency work and clearing the four high-severity findings blocking the image scan: three in golang.org/x/crypto, one in go.etcd.io/etcd/client/pkg/v3.

This binary is built from upstream prometheus-operator source, so its dependency versions are upstream's, not ours. The build carries go get overrides for the ones upstream hasn't caught up on — and those name exact versions, so each goes stale as new advisories land against the version it names. That had already happened: the override named x/crypto v0.53.0, which has since had all three advisories filed against it, so the line written to clear findings had become the reason for them.

Upgrading lets two of the four overrides go:

upstream at v0.93.1 outcome
x/net v0.57.0 override dropped — ahead of the old pin, keeping it downgrades
x/text v0.40.0 override dropped — ahead of the old pin, keeping it downgrades
x/crypto v0.54.0 override kept at v0.56.0 — GO-2026-6303/6354/6355
etcd/client/pkg/v3 override kept at v3.6.14 — GO-2026-6107

How the two survivors were chosen. This branch was first pushed with no overrides at all, to test whether the upgrade alone was enough. CI's scan reported exactly these four findings, so both overrides are reinstated on evidence rather than assumption — and the two that were dropped are confirmed unnecessary by the same run.

Worth noting a local build of v0.93.1 scanned clean, which was misleading; the CI scan of the built image is the authority, and #1003 is what made its findings legible.

The Dockerfile comment now says to check what upstream resolves before touching these, and to delete each one once upstream passes it — so the next finding here reads as a pin to retire rather than an upstream regression.

🤖 Generated with Claude Code

@greptile-apps

greptile-apps Bot commented Sep 4, 2026

Copy link
Copy Markdown

Greptile Summary

Updates the bundled prometheus-config-reloader from v0.91.0 to v0.93.1 and revises its dependency overrides.

  • Raises the x/crypto override to v0.56.0.
  • Removes obsolete x/net and x/text overrides.
  • Documents when and how to retire the remaining override.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
docker/Dockerfile Updates the reloader source tag and dependency override without an identified blocking failure.

Reviews (8): Last reviewed commit: "CP-47363: Upgrade prometheus-config-relo..." | Re-trigger Greptile

@evan-cz evan-cz changed the title CP-47363: Update prometheus-config-reloader and its pins CP-47363: Drop the prometheus-config-reloader pins Sep 4, 2026
@evan-cz evan-cz changed the title CP-47363: Drop the prometheus-config-reloader pins CP-47363: Update prometheus-config-reloader to 0.93.1 Sep 4, 2026
@evan-cz
evan-cz force-pushed the CP-47363-reloader branch 2 times, most recently from 2beec26 to dc0b095 Compare September 4, 2026 17:06
@evan-cz evan-cz changed the title CP-47363: Update prometheus-config-reloader to 0.93.1 CP-47363: Upgrade prometheus-config-reloader to v0.93.1 Sep 4, 2026
@evan-cz

evan-cz commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Rebuilding against the re-tagged ghcr.io/cloudzero/alloy:v1.19.2-patch-1, which now carries the etcd v3.6.14 fix for GO-2026-6107. No change to this branch — the tag moved, the pin did not.

Brings the bundled config reloader up two minor versions, from v0.91.0,
picking up upstream's own dependency work and clearing the three
high-severity x/crypto findings that were blocking the image scan.

This binary is built from upstream prometheus-operator source, so its
dependency versions are upstream's rather than this repository's, and
the build carries go get overrides for the ones upstream has not caught
up on. Those overrides name exact versions, so each goes stale as new
advisories land against the version it names. That had already
happened: the override named x/crypto v0.53.0, which has since had
three advisories filed against it, so the line written to clear
findings had become the reason for them.

Upgrading lets two of the three surviving overrides go. Upstream now
ships x/net v0.57.0 and x/text v0.40.0, both ahead of what the old pins
asked for, so keeping those would have downgraded them. Only x/crypto
still needs raising.

No etcd override is added. The image scan reports an etcd advisory, but
that dependency reaches the image through the bundled Alloy binary
rather than this one, so an override here cannot affect it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants