CP-47363: Upgrade prometheus-config-reloader to v0.93.1 - #1004
Open
evan-cz wants to merge 1 commit into
Open
Conversation
Greptile SummaryUpdates the bundled prometheus-config-reloader from v0.91.0 to v0.93.1 and revises its dependency overrides.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (8): Last reviewed commit: "CP-47363: Upgrade prometheus-config-relo..." | Re-trigger Greptile |
evan-cz
force-pushed
the
CP-47363-reloader
branch
from
September 4, 2026 16:54
cc0c907 to
a83ec43
Compare
evan-cz
force-pushed
the
CP-47363-reloader
branch
from
September 4, 2026 16:54
a83ec43 to
7078fd8
Compare
amfelso
approved these changes
Sep 4, 2026
evan-cz
force-pushed
the
CP-47363-reloader
branch
2 times, most recently
from
September 4, 2026 17:06
2beec26 to
dc0b095
Compare
evan-cz
force-pushed
the
CP-47363-reloader
branch
from
September 4, 2026 17:42
dc0b095 to
d24d2f8
Compare
evan-cz
force-pushed
the
CP-47363-reloader
branch
from
September 4, 2026 18:03
d24d2f8 to
fd041ab
Compare
Contributor
Author
|
Rebuilding against the re-tagged |
evan-cz
force-pushed
the
CP-47363-reloader
branch
from
September 4, 2026 18:41
fd041ab to
33f0b43
Compare
evan-cz
force-pushed
the
CP-47363-reloader
branch
from
September 4, 2026 18:59
33f0b43 to
7014624
Compare
Brings the bundled config reloader up two minor versions, from v0.91.0, picking up upstream's own dependency work and clearing the three high-severity x/crypto findings that were blocking the image scan. This binary is built from upstream prometheus-operator source, so its dependency versions are upstream's rather than this repository's, and the build carries go get overrides for the ones upstream has not caught up on. Those overrides name exact versions, so each goes stale as new advisories land against the version it names. That had already happened: the override named x/crypto v0.53.0, which has since had three advisories filed against it, so the line written to clear findings had become the reason for them. Upgrading lets two of the three surviving overrides go. Upstream now ships x/net v0.57.0 and x/text v0.40.0, both ahead of what the old pins asked for, so keeping those would have downgraded them. Only x/crypto still needs raising. No etcd override is added. The image scan reports an etcd advisory, but that dependency reaches the image through the bundled Alloy binary rather than this one, so an override here cannot affect it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
evan-cz
force-pushed
the
CP-47363-reloader
branch
from
September 4, 2026 20:53
7014624 to
fbdd9bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1003.
Brings the bundled config reloader up two minor versions (v0.91.0 → v0.93.1), picking up upstream's own dependency work and clearing the four high-severity findings blocking the image scan: three in
golang.org/x/crypto, one ingo.etcd.io/etcd/client/pkg/v3.This binary is built from upstream prometheus-operator source, so its dependency versions are upstream's, not ours. The build carries
go getoverrides for the ones upstream hasn't caught up on — and those name exact versions, so each goes stale as new advisories land against the version it names. That had already happened: the override namedx/crypto v0.53.0, which has since had all three advisories filed against it, so the line written to clear findings had become the reason for them.Upgrading lets two of the four overrides go:
x/netx/textx/cryptoetcd/client/pkg/v3How the two survivors were chosen. This branch was first pushed with no overrides at all, to test whether the upgrade alone was enough. CI's scan reported exactly these four findings, so both overrides are reinstated on evidence rather than assumption — and the two that were dropped are confirmed unnecessary by the same run.
Worth noting a local build of v0.93.1 scanned clean, which was misleading; the CI scan of the built image is the authority, and #1003 is what made its findings legible.
The Dockerfile comment now says to check what upstream resolves before touching these, and to delete each one once upstream passes it — so the next finding here reads as a pin to retire rather than an upstream regression.
🤖 Generated with Claude Code