Optimize calculateFreebuffStreak to single-pass iteration - #1260
Open
pavankumar-vh wants to merge 1 commit into
Open
Optimize calculateFreebuffStreak to single-pass iteration#1260pavankumar-vh wants to merge 1 commit into
pavankumar-vh wants to merge 1 commit into
Conversation
The function iterated through usageDates twice: 1. Once with filter() to build the usageDateSet 2. Once with reduce() to find lastUsageDate This is O(2n) when it could be O(n) by combining both operations in a single loop. Combined both operations into one loop, building the set and tracking the latest date simultaneously. This is more efficient and clearer in intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Optimize the
calculateFreebuffStreakfunction incommon/src/util/freebuff-streak.tsto use a single pass instead of two iterations.Bug Description
The function iterated through
usageDatestwice:filter()to build theusageDateSetreduce()to findlastUsageDateThis is O(2n) when it could be O(n) by combining both operations in a single loop.
Fix
Combined both operations into one loop, building the set and tracking the latest date simultaneously. This is more efficient and clearer in intent.
Testing
All existing tests pass (14/14).
Files Changed
common/src/util/freebuff-streak.ts- Single-pass iteration optimizationScope
This change only touches
common/src/util/freebuff-streak.ts(a single file in the approvedcommon/area).