Skip to content

Optimize calculateFreebuffStreak to single-pass iteration #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavankumar-vh wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −7
Open

Optimize calculateFreebuffStreak to single-pass iteration #1260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions common/src/util/freebuff-streak.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,15 @@ export function calculateFreebuffStreak(params: {
lastUsageDate: string | null
} {
const { usageDates, todayDateKey } = params
const usageDateSet = new Set(
usageDates.filter((date) => date <= todayDateKey),
)
const lastUsageDate = usageDates.reduce<string | null>((latest, date) => {
if (date > todayDateKey) return latest
return latest === null || date > latest ? date : latest
}, null)
const usageDateSet = new Set<string>()
let lastUsageDate: string | null = null
for (const date of usageDates) {
if (date > todayDateKey) continue
usageDateSet.add(date)
if (lastUsageDate === null || date > lastUsageDate) {
lastUsageDate = date
}
}
const todayUsed = usageDateSet.has(todayDateKey)

let anchorDateKey = todayDateKey
Expand Down
Loading