refactor: split MessageKeys and localize remaining strings - #100
Merged
Conversation
…hardcoded strings Split the monolithic MessageKeys.java (2,789 lines, ~1,298 constants) into 6 focused domain files: CommonKeys, CommandKeys, HelpKeys, AdminKeys, GuiKeys, and AdminGuiKeys. Consolidated ~25 duplicate keys into shared CommonKeys.Common constants. Localized ~70 remaining hardcoded strings in territory display banners, update notifications, death broadcasts, and admin handlers. Added ~467 new translation entries per locale across all 10 supported languages.
This was referenced Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MessageKeys.java(2,789 lines, ~1,298 constants) into 6 focused domain files:CommonKeys,CommandKeys,HelpKeys,AdminKeys,GuiKeys,AdminGuiKeysCommonKeys.CommonconstantsTest plan
./gradlew :HyperFactions:shadowJar)