fix: localize player accessibility labels - #2867
Open
pixel-daemon-bot wants to merge 1 commit into
Open
pixel-daemon-bot wants to merge 1 commit into
pixel-daemon-bot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces hardcoded playback accessibility labels with the existing localized string resources.
Changes
Anterior/Siguienteaccessibility labels with localized Previous/Next resources;Carátula de ...with the existing localized album-art resource;Pausar/Reproducirlabels with the existing localized Pause/Play resources;Scope
Only these files are changed:
app/src/main/java/com/theveloper/pixelplay/presentation/components/UnifiedPlayerSheetShared.ktapp/src/main/java/com/theveloper/pixelplay/presentation/components/player/AnimatedPlaybackControls.ktNo new string keys were required because existing localized resources were reused.
Validation
Passed locally:
:app:compileDebugKotlin:app:processDebugResourcesgit diff --checkA repository-wide search confirmed that the targeted Spanish accessibility literals are no longer present in production code.
Notes
This change improves localization and accessibility consistency for playback controls.
It is intentionally limited to these hardcoded accessibility labels. Other hardcoded user-visible strings remain outside the scope of this PR and will be addressed separately.
Important
Do NOT claim the application is now fully localized.
Do NOT claim that a Samsung-specific issue was fixed by this PR.