Skip to content

fix: localize player accessibility labels #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixel-daemon-bot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: localize player accessibility labels #2867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...rc/main/java/com/theveloper/pixelplay/presentation/components/UnifiedPlayerSheetShared.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,13 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.hapticfeedback.HapticFeedbackType
import androidx.compose.ui.platform.LocalHapticFeedback
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import coil.size.Size
import com.theveloper.pixelplay.R
import com.theveloper.pixelplay.data.model.Song
import com.theveloper.pixelplay.ui.theme.GoogleSansRounded

Expand Down Expand Up @@ -92,7 +94,7 @@ internal fun MiniPlayerContentInternal(
key(song.id) {
SmartImage(
model = albumArtModel,
contentDescription = "Carátula de ${song.title}",
contentDescription = stringResource(R.string.common_album_art_for_title, song.title),
shape = CircleShape,
targetSize = Size(150, 150),
modifier = Modifier.size(44.dp),
Expand Down Expand Up @@ -166,7 +168,7 @@ internal fun MiniPlayerContentInternal(
) {
Icon(
imageVector = Icons.Rounded.SkipPrevious,
contentDescription = "Anterior",
contentDescription = stringResource(R.string.common_previous_track),
tint = LocalMaterialTheme.current.primary,
modifier = Modifier.size(22.dp)
)
Expand All @@ -191,7 +193,7 @@ internal fun MiniPlayerContentInternal(
) {
Icon(
imageVector = if (isPlaying) Icons.Rounded.Pause else Icons.Rounded.PlayArrow,
contentDescription = if (isPlaying) "Pausar" else "Reproducir",
contentDescription = if (isPlaying) stringResource(R.string.common_pause) else stringResource(R.string.common_play),
tint = LocalMaterialTheme.current.onPrimary,
modifier = Modifier.size(22.dp)
)
Expand All @@ -213,7 +215,7 @@ internal fun MiniPlayerContentInternal(
) {
Icon(
imageVector = Icons.Rounded.SkipNext,
contentDescription = "Siguiente",
contentDescription = stringResource(R.string.common_next_track),
tint = LocalMaterialTheme.current.primary,
modifier = Modifier.size(22.dp)
)
Expand Down
8 changes: 5 additions & 3 deletions .../java/com/theveloper/pixelplay/presentation/components/player/AnimatedPlaybackControls.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@ import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.graphicsLayer
import androidx.compose.ui.hapticfeedback.HapticFeedbackType
import androidx.compose.ui.platform.LocalHapticFeedback
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
import com.theveloper.pixelplay.R
import com.theveloper.pixelplay.presentation.components.LocalMaterialTheme
import kotlinx.coroutines.delay
import racra.compose.smooth_corner_rect_library.AbsoluteSmoothCornerShape
Expand Down Expand Up @@ -165,7 +167,7 @@ fun AnimatedPlaybackControls(
) {
Icon(
imageVector = Icons.Rounded.SkipPrevious,
contentDescription = "Anterior",
contentDescription = stringResource(R.string.common_previous_track),
tint = tintPreviousIcon,
modifier = Modifier.size(iconSize)
)
Expand Down Expand Up @@ -238,7 +240,7 @@ fun AnimatedPlaybackControls(
) {
Icon(
imageVector = Icons.Rounded.SkipNext,
contentDescription = "Siguiente",
contentDescription = stringResource(R.string.common_next_track),
tint = tintNextIcon,
modifier = Modifier.size(iconSize)
)
Expand All @@ -261,7 +263,7 @@ private fun MorphingPlayPauseIcon(
) { playing ->
Icon(
imageVector = if (playing) Icons.Rounded.Pause else Icons.Rounded.PlayArrow,
contentDescription = if (playing) "Pausar" else "Reproducir",
contentDescription = if (playing) stringResource(R.string.common_pause) else stringResource(R.string.common_play),
tint = tint,
modifier = Modifier.size(size)
)
Expand Down