Skip to content

01a04757 - Cover every account-merge confirmation state - #29

Draft
TaprootFreakAI wants to merge 4 commits into
RealUnitCH:developfrom
TaprootFreakAI:01a04757-account-merge-e2e
Draft

01a04757 - Cover every account-merge confirmation state#29
TaprootFreakAI wants to merge 4 commits into
RealUnitCH:developfrom
TaprootFreakAI:01a04757-account-merge-e2e

Conversation

@TaprootFreakAI

Copy link
Copy Markdown
Collaborator

EN:
This PR adds Playwright coverage for every remaining account-merge confirmation state on realunit.app, including empty OTP, 404, DeadLetter, a Failed job, German copy, and the RealUnit logo on success.

DE:
Dieser PR ergänzt Playwright-Abdeckung für jeden noch offenen Bestätigungszustand von Zusammenlegen auf realunit.app, inklusive leerem OTP, 404, DeadLetter, fehlgeschlagenem Job, deutscher Kopie und RealUnit-Logo bei Erfolg.

Details

The page at /account-merge is the RealUnit confirmation frontend for merge mails. Existing tests already covered success, 409, 400, retry, and most job paths. This adds the remaining user-visible states.

The confirmation page already handles these API states; the suite now
opens each one the way a mail link would.
Empty OTP also asserts the loading state is hidden. DeadLetter counts
the confirm request like the existing Failed case.
A regression that skipped polling would still show unavailable. The
test now requires the confirm and the job request.
@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review August 29, 2026 16:02
@TaprootFreakAI

TaprootFreakAI commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 2 review passes.
This PR adds Playwright coverage for every remaining account-merge confirmation state on realunit.app, including empty OTP, 404, DeadLetter (immediate and after poll), a Failed job after polling, German copy, and the RealUnit logo on success.

DE:
Bereit nach 2 Review-Durchläufen.
Dieser PR ergänzt Playwright-Abdeckung für jeden noch offenen Bestätigungszustand von Zusammenlegen auf realunit.app, inklusive leerem OTP, 404, DeadLetter (sofort und nach Poll), fehlgeschlagenem Job nach dem Poll, deutscher Kopie und RealUnit-Logo bei Erfolg.

Details

Head 87654609762cd0812dad37c2435471a4f7e34a11 (verified). mergeable: MERGEABLE, mergeStateStatus: CLEAN.

CI on this head: Quality success, Screenshots (visual regression) success.

Grok quality + logic: 0 findings.
Codex quality + logic: 0 findings.

@TaprootFreakAI
TaprootFreakAI marked this pull request as draft August 29, 2026 16:13
A ticket that is Pending on confirm and DeadLetter on the first job
GET must show unavailable and must have issued the job request.
@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review August 29, 2026 18:42
@TaprootFreakAI
TaprootFreakAI marked this pull request as draft September 2, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant