Skip to content

01a04757 - Cover every account-merge confirmation state #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TaprootFreakAI wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

01a04757 - Cover every account-merge confirmation state #29

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3653b95
test(account-merge): cover empty otp, 404, DeadLetter and Failed jobs
TaprootFreakAI Aug 29, 2026
752b745
test(account-merge): match sibling assertions and printWidth
TaprootFreakAI Aug 29, 2026
1a8d178
test(account-merge): count the job GET on a Failed poll
TaprootFreakAI Aug 29, 2026
8765460
test(account-merge): cover DeadLetter after a pending job poll
TaprootFreakAI Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 118 additions & 0 deletions tests/behavior.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,124 @@ test.describe('account-merge flow', () => {
await expect(page.locator('#state-invalid h1')).toHaveText(expected);
});

test('an empty otp shows the invalid state and makes no confirm request', async ({ page }) => {
const confirmCalls = [];
await page.route(MERGE_CONFIRM_ENDPOINT, (route) => {
confirmCalls.push(route.request().url());
route.fulfill({ status: 200, contentType: 'application/json', body: '{}' });
});
await page.goto('/account-merge/?otp=');
await expect(page.locator('#state-invalid')).toBeVisible();
await expect(page.locator('#state-loading')).toBeHidden();
expect(confirmCalls).toEqual([]);
});

test('a 404 response shows the invalid state', async ({ page }) => {
await page.route(MERGE_CONFIRM_ENDPOINT, (route) =>
route.fulfill({ status: 404, contentType: 'application/json', body: '{}' }),
);
await page.goto('/account-merge/?otp=abc');
await expect(page.locator('#state-invalid')).toBeVisible();
});

test('a 202 ticket already DeadLetter skips job polling and shows unavailable', async ({
page,
}) => {
let confirmCalls = 0;
let jobCalls = 0;
await page.route(MERGE_CONFIRM_ENDPOINT, (route) => {
confirmCalls += 1;
route.fulfill({
status: 202,
contentType: 'application/json',
body: JSON.stringify({
uid: 'job-1',
status: 'DeadLetter',
expectedSeconds: 2,
}),
});
});
await page.route(MERGE_JOB_ENDPOINT, (route) => {
jobCalls += 1;
route.fulfill({ status: 200, contentType: 'application/json', body: '{}' });
});
await page.goto('/account-merge/?otp=abc');
await expect(page.locator('#state-unavailable')).toBeVisible({ timeout: 10000 });
expect(confirmCalls).toBe(1);
expect(jobCalls).toBe(0);
});

test('a job that becomes DeadLetter after polling shows unavailable', async ({ page }) => {
let confirmCalls = 0;
let jobCalls = 0;
await page.route(MERGE_CONFIRM_ENDPOINT, (route) => {
confirmCalls += 1;
route.fulfill({
status: 202,
contentType: 'application/json',
body: JSON.stringify({ uid: 'job-1', status: 'Pending', expectedSeconds: 2 }),
});
});
await page.route(MERGE_JOB_ENDPOINT, (route) => {
jobCalls += 1;
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({ uid: 'job-1', status: 'DeadLetter' }),
});
});
await page.goto('/account-merge/?otp=abc');
await expect(page.locator('#state-unavailable')).toBeVisible({ timeout: 10000 });
expect(confirmCalls).toBe(1);
expect(jobCalls).toBe(1);
});

test('a job that becomes Failed after polling shows unavailable', async ({ page }) => {
let confirmCalls = 0;
let jobCalls = 0;
await page.route(MERGE_CONFIRM_ENDPOINT, (route) => {
confirmCalls += 1;
route.fulfill({
status: 202,
contentType: 'application/json',
body: JSON.stringify({ uid: 'job-1', status: 'Pending', expectedSeconds: 2 }),
});
});
await page.route(MERGE_JOB_ENDPOINT, (route) => {
jobCalls += 1;
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({ uid: 'job-1', status: 'Failed' }),
});
});
await page.goto('/account-merge/?otp=abc');
await expect(page.locator('#state-unavailable')).toBeVisible({ timeout: 10000 });
expect(confirmCalls).toBe(1);
expect(jobCalls).toBe(1);
});

test('confirmed state shows the RealUnit logo', async ({ page }) => {
await page.route(MERGE_CONFIRM_ENDPOINT, (route) =>
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({ kycHash: 'x' }),
}),
);
await page.goto('/account-merge/?otp=abc');
await expect(page.locator('#state-confirmed')).toBeVisible();
await expect(page.locator('img.logo')).toBeVisible();
await expect(page.locator('img.logo')).toHaveAttribute('src', '/assets/realunit-logo.png');
});

test('?lang=de renders German copy and sets <html lang="de">', async ({ page }) => {
await page.goto('/account-merge/?mock=invalid&lang=de');
await expect(page.locator('html')).toHaveAttribute('lang', 'de');
const expected = await page.evaluate(() => window.RealUnitMerge.I18N.de['invalid.title']);
await expect(page.locator('#state-invalid h1')).toHaveText(expected);
});

test('an ?api= override sends the confirmation to that API base', async ({ page }) => {
let requestedUrl = null;
await page.route(MERGE_CONFIRM_ENDPOINT, (route) => {
Expand Down
Loading