Skylab: stored resources are no longer re-valued when an upgrade finishes (0.4.0)

[rorychatt]

0.4.0 changes how a Skylab farm's stored resources are counted around an upgrade.

Before 0.4.0

A farm kept filling its storage while it upgraded. When the upgrade finished, everything stored until then was re-valued at the new level's production rate. For a Credit Farm going from level 1 to 2 that was about +40% on the stored amount. You couldn't collect during an upgrade, so waiting for it to finish always paid more.

From 0.4.0

The player asked that anything already mined can always be collected, from a farm that is out of power, switched off or being upgraded; only production stops. So:

• An upgrading farm stops producing. What it has stored can be collected during the upgrade.
• When the upgrade finishes, the stored amount keeps its value; it isn't re-valued at the new rate.
• Collecting during an upgrade and collecting after it pay the same.

Pilots who waited for an upgrade to finish before collecting no longer get the extra ~40%.

Question

Keep the 0.4.0 behaviour, or bring back a bonus on finished upgrades? If we bring it back, it should also apply to collecting during an upgrade, or waiting will still pay more.

To bring it back:

• Server: finalize_upgrade in server/src/skylab/mod.rs.
• Tests: "an upgrade keeping the stored value" in server/src/skylab/tests.rs.

[rorychatt]

Decision: keep the 0.4.0 behaviour. What a farm has stored keeps its value when an upgrade finishes, and anything already mined can be collected during an upgrade, so collecting early or late pays the same. No bonus on finished upgrades.