feat: security role scaffold applier for pp-security-role - #96
Open
zekelinAlex wants to merge 3 commits into
Open
zekelinAlex wants to merge 3 commits into
zekelinAlex wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First consumer of SolutionRootComponentPatcher: pp-security-role's whole post-action is one RootComponent append (type 20, by id), so the applier just wires the patcher. The template's componentType tag says SecurityRole and resolves to Role through the registry alias.
The sandbox run earned its keep - it showed the patcher calling the full workspace Write, which reformatted every sibling file it could reach and silently deleted the empty Relationships.xml. It now writes only the manifest via WriteSolutionManifest. Also taught the writer to indent the first children added to a previously empty container, so a fresh RootComponents doesn't come out as one long line.
Parity vs the old script: RootComponents byte-identical, the only remaining diff is xsi:nil tags collapsing back to the template's single-line form (the old script's XmlDocument.Save is what expanded them).
Stacked on the control-parameter applier branch; merge order stays the plan's.