refactor: consume inventory scanning directly from TLibs - #41
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe project updates TLibs to version 2.1.0, removes the direct TFMCCore dependency and plugin hard dependency, and changes three item scan imports to use TLibs. ChangesItem scan dependency migration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: 🟡 Moderate · up to The plugin now depends on TLibs 2.1.0 for its item scanning callbacks, but that version is not yet published to the configured Maven repository. Builds will fail until it is. Merge only after TLibs 2.1.0 is released and CI passes against the published artifact. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
A rabbit hops beside the build, Comment |
Subscribe food-freshness and fish-conversion callbacks through TLibs. Remove the Core Maven/runtime dependency and pin TLibs 2.1.0; callback behavior and subscription lifecycle stay unchanged.
Validation: baseline and final Maven verify passed 180 tests; runtime JAR checks passed. Final verification used the source-built TLibs candidate.
Provider dependency: TLibs 2.1.0 is now published; pinned-release CI has been rerun against that artifact. Update the coordinated server plugin set as documented in Docs.
Coordinated PRs
TLibs 2.1.0 and RPCharacters 2.1.0 are published with verified release artifacts. No server deployment has been performed.
Summary by CodeRabbit