Skip to content

refactor: consume inventory scanning directly from TLibs - #41

Merged
ryanbarlow97 merged 2 commits into
mainfrom
refactor/core-ownership
Sep 24, 2026
Merged

ryanbarlow97 merged 2 commits into
mainfrom
refactor/core-ownership

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Subscribe food-freshness and fish-conversion callbacks through TLibs. Remove the Core Maven/runtime dependency and pin TLibs 2.1.0; callback behavior and subscription lifecycle stay unchanged.

Validation: baseline and final Maven verify passed 180 tests; runtime JAR checks passed. Final verification used the source-built TLibs candidate.

Provider dependency: TLibs 2.1.0 is now published; pinned-release CI has been rerun against that artifact. Update the coordinated server plugin set as documented in Docs.

Coordinated PRs

  1. Scanner: TLibs #30, Cooking #41.
  2. Focus: RPCharacters #27, Research #4, Magic #24 (also scanner).
  3. Letters: BirdMessenger #24.
  4. Core removal and manual update guide: TFMCCore #24, Docs #45.

TLibs 2.1.0 and RPCharacters 2.1.0 are published with verified release artifacts. No server deployment has been performed.

Summary by CodeRabbit

  • Compatibility
    • The plugin no longer requires TFMCCore to be installed.
    • Updated the required TLibs version to 2.1.0.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 9439571d-c602-46f5-b7b8-18e547db5de3

📥 Commits

Reviewing files that changed from the base of the PR and between c2f115b and 90844e3.

📒 Files selected for processing (5)
  • pom.xml
  • src/main/java/net/tfminecraft/cooking/Cooking.java
  • src/main/java/net/tfminecraft/cooking/fishing/LegacyFishScan.java
  • src/main/java/net/tfminecraft/cooking/manager/TagManager.java
  • src/main/resources/plugin.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The project updates TLibs to version 2.1.0, removes the direct TFMCCore dependency and plugin hard dependency, and changes three item scan imports to use TLibs.

Changes

Item scan dependency migration

Layer / File(s) Summary
Dependency declarations
pom.xml, src/main/resources/plugin.yml
The TLibs version changes to 2.1.0. The direct TFMCCore dependency and its wildcard exclusions are removed from the Maven configuration. TFMCCore is removed from the plugin’s hard dependency list.
Item scan imports
src/main/java/net/tfminecraft/cooking/Cooking.java, src/main/java/net/tfminecraft/cooking/fishing/LegacyFishScan.java, src/main/java/net/tfminecraft/cooking/manager/TagManager.java
The item scan service and handler imports change from TFMCCore packages to TLibs packages.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: carolinebondhus

Merge Risk: 🟡 Moderate · up to 90844

The plugin now depends on TLibs 2.1.0 for its item scanning callbacks, but that version is not yet published to the configured Maven repository. Builds will fail until it is. Merge only after TLibs 2.1.0 is released and CI passes against the published artifact.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: consuming inventory scanning directly from TLibs. It is concise and specific.
Description check ✅ Passed The description explains the refactor, dependency removal, TLibs version, validation results, rollout dependencies, and coordinated pull requests. It does not use all template headings or explicitly d…
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit hops beside the build,
TLibs steps into the field.
Old imports leave, new paths appear,
The plugin list is trimmed and clear.
A carrot rests beside the code,
Then off the rabbit softly strode.

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 94a35d8 into main Sep 24, 2026
2 of 3 checks passed
@ryanbarlow97
ryanbarlow97 deleted the refactor/core-ownership branch September 24, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant