refactor(bringup): one Python owner of the start scripts' launch defaults - #460
Merged
Merged
Conversation
model=koishi/qwen3.8-flash-next-mtp gate='python3 -m pytest tests --ignore=tests/e2e && ruff check tapscribe tests && ruff format --check tapscribe tests'
…ults start.sh and start.ps1 no longer derive the host, ports, model and language each on their own. Both run `python -m tapscribe.bringup_defaults` and parse its KEY=value lines. `__main__.build_parser` imports the same constants, so a bare `python -m tapscribe` launch gets the same values. Closes #357
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start.shandstart.ps1now read their launch defaults from one module, not from two copies.tapscribe/bringup_defaults.pyowns the host, the recorder and live ports, the model and the language. It resolves theSX_*overrides and--lan, then printsKEY=valuelines.python -m tapscribe.bringup_defaultsand parse its output.python -m tapscribeargparse defaults import the same constants.tests/test_bringup_defaults.pycoversresolve, the output format, and a check that each script uses the module.Gate:
python3 -m pytest tests --ignore=tests/e2e && ruff check tapscribe tests && ruff format --check tapscribe testsis green.Delegated slice (experiment 357, winner leg qwen). Claude reviewed the result with /code-review and /simplify.
Closes #357