Graph Expression Parser and ROS_DOMAIN_ID - #331
Draft
0x53A wants to merge 4 commits into
Draft
Conversation
Restore synchronous, history-enabled graph initialization after review of the asynchronous bootstrap experiment. Accept rmw_zenoh SYSTEM_DEFAULT QoS encodings, preserve node domain and key-expression settings for built-in services, and add regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was LLM generated in a hurry, which is why I am opening it as draft. It contains fixes for two issues:
The default domain of
0was assumed in a few places, and, the key parser failed on valid expressions.I'll have some time ~late September, otherwise please treat this like an issue/bug report and extract the two relevant changes.