_frontend/cli.py: Update default min-version for bst init - #2175
Merged
Conversation
This is implicitly required by tests after creating the 2.8.0.dev0 tag.
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
August 17, 2026 12:53
Contributor
|
LGTM |
| @click.option( | ||
| "--min-version", | ||
| type=click.STRING, | ||
| default="2.7", |
Contributor
There was a problem hiding this comment.
In the test, is it worth adding a memo, along the lines of:
assert project_conf.get_str("min-version") == get_default_min_version(), 'project min version does not equal default min version. If this is failing and repository was recently tagged, a version update PR is required for this test to pass again.'
Contributor
Author
There was a problem hiding this comment.
Yes, or maybe we can find a way to streamline the process. But let's handle this outside of this minimal update, after the final 2.8.0 release.
Contributor
There was a problem hiding this comment.
agreed, getting the CI working again is priority.
abderrahim
approved these changes
Aug 17, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is implicitly required by tests after creating the 2.8.0.dev0 tag.