Skip to content

_frontend/cli.py: Update default min-version for bst init #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juergbi merged 1 commit into from
Aug 17, 2026
Merged

_frontend/cli.py: Update default min-version for bst init #2175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/buildstream/_frontend/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ def help_command(ctx, command):
@click.option(
"--min-version",
type=click.STRING,
default="2.7",

@nathanwilliams-ct nathanwilliams-ct Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the test, is it worth adding a memo, along the lines of:

assert project_conf.get_str("min-version") == get_default_min_version(), 'project min version does not equal default min version. If this is failing and repository was recently tagged, a version update PR is required for this test to pass again.'

@juergbi juergbi Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, or maybe we can find a way to streamline the process. But let's handle this outside of this minimal update, after the final 2.8.0 release.

@nathanwilliams-ct nathanwilliams-ct Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, getting the CI working again is priority.

@nathanwilliams-ct nathanwilliams-ct Aug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2177 created this as a follow-up.

default="2.8",
show_default=True,
help="The required format version",
)
Expand Down
Loading