Skip to content

fix(desktop): stop inspector summary loading line flickering on usage refresh - #4843

Merged
Astro-Han merged 1 commit into
apache:mainfrom
uzqw:fix/inspector-summary-flicker
Sep 6, 2026
Merged

fix(desktop): stop inspector summary loading line flickering on usage refresh#4843
Astro-Han merged 1 commit into
apache:mainfrom
uzqw:fix/inspector-summary-flicker

Conversation

@uzqw

@uzqw uzqw commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

The inspector's summary loading line appeared whenever summaryLoading
was set. A live session re-reads its summary on every usage update
without clearing the last one, so that line was inserted and removed on
each refresh and the timeline jumped.

Show the line only while there is no summary yet, same as the trace
loader above. Background refreshes stay on aria-busy.

Verification

  • npx biome check on the touched file — clean
  • Manual: live session usage updates no longer flash the loading line
    or jump the timeline; first load with no summary still shows it
  • Not run: npm test (one boolean gate; no new test)
  • Not attached: before/after recording (please say if you want one)

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Maka — drafted the gate and the comment; I reviewed
the loading/refresh path and the wording.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@github-actions github-actions Bot added the effort/XS Under 10 readable lines label Sep 5, 2026
… refresh

The inspector's summary loading line appeared whenever summaryLoading
was set. A live session re-reads its summary on every usage update
without clearing the last one, so that line was inserted and removed
on each refresh and the timeline jumped.

Show it only while there is no summary yet, same as the trace loader
above. Background refreshes stay on aria-busy.

Generated-by: Maka
@uzqw
uzqw force-pushed the fix/inspector-summary-flicker branch from 2541662 to c5ebb43 Compare September 5, 2026 09:11

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Astro-Han
Astro-Han merged commit 70d1516 into apache:main Sep 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/XS Under 10 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants